Fixed #1473: Unexpected behavior when updation of talawa admin members profile.

[Devesh326]

What kind of change does this PR introduce?

Bugfix

Issue Number:

Fixes #1473

Did you add tests for your changes?

No

Snapshots/Videos:

Palisodes.Foundation.Talawa.Members.mp4

Summary

Solves the following issues:

1. When attempting to update a member's profile, it required changing the email ID.
2. Despite updating the profile, the member's actual profile remained unchanged. Instead, the user's (your) profile credentials w were updated to match the member's credentials.

Have you read the contributing guide?

Yes

[github-actions]

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

1. The overall code coverage drops below the target threshold of the repository
2. Any file in the pull request has code coverage levels below the repository threshold
3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

1. comments in this PR or
2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

1. arbitrators of future discussions with other contributors about the validity of your changes
2. point of contact for evaluating the validity of your work
3. person who verifies matching issues by others that should be closed.
4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

1. PRs with issues not assigned to you will be closed by the reviewer
2. Fix the first comment in the PR so that each issue listed automatically closes

Other

1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
2. Read the CONTRIBUTING.md file make

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (378248d) 97.29% compared to head (2dfc12a) 97.28%.
Report is 6 commits behind head on develop.

❗ Current head 2dfc12a differs from pull request most recent head b4f506a. Consider uploading reports for the commit b4f506a to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1499      +/-   ##
===========================================
- Coverage    97.29%   97.28%   -0.01%     
===========================================
  Files          133      132       -1     
  Lines         3396     3393       -3     
  Branches      1038     1038              
===========================================
- Hits          3304     3301       -3     
  Misses          87       87              
  Partials         5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nitishkumar333]

@Devesh326 If the user edits his own profile then how will leftDrawer update as you have removed localStorage ?

[Cioppolo14]

@noman2002 @anwersayeed Can you review this PR?

[Devesh326]

@Devesh326 If the user edits his own profile then how will leftDrawer update as you have removed localStorage ?

Yes, I've addressed that in the latest commit. Now, the system checks if the member's ID matches the root user's ID stored in the localStorage during login. Only under this condition, it utilizes localStorage to update the profile of the root user.

[palisadoes]

You will need to pay attention to this PR where we are getting rid of using localstorage that was causing serious difficulties.

• Addressing Continuous Refreshing in Development Environment #1466

[Devesh326]

Okay sir, will do the necessary changes

[Devesh326]

Hey @palisadoes @noman2002 @anwersayeed ,

This Bug also involves a few changes in the Talawa-Api. I've already implemented the necessary changes. Should I open a new issue in the Talawa API repository and create a corresponding pull request to address this issue?

[palisadoes]

Yes

[noman2002]

Changes looks fine to me.

[palisadoes]

Please fix the failing test. The your code doesn't match the schema in some ways. That is why introspection is failing.

[noman2002]

Please fix the failing test. The your code doesn't match the schema in some ways. That is why introspection is failing.

Is the introspection issue fixed now ?

[palisadoes]

Yes

[Devesh326]

Sure, I'll review and push a commit to verify if the test passes.