-
-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all hard coded localhosts with env constant variables #1497
Replace all hard coded localhosts with env constant variables #1497
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
@NayOoLwin5 Please fix the test application failing tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I don't see the need to create the
REACT_ADMIN_FRONTEND_HOST
variable when relative variables would seem to be equally suitable. - Let us know why this is necessary
- The replacement of
localhost
with theBACKEND_URL
is clearly necessary.
|
Please fix the failing tests |
Please let me know how I can reproduce the failed tests. @palisadoes |
…awa-admin into bugfix/localhost_replacement
Hi @palisadoes, the test should work fine now. The issue was removing dynamic env |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1497 +/- ##
========================================
Coverage 97.29% 97.29%
========================================
Files 132 132
Lines 3395 3396 +1
Branches 1038 1038
========================================
+ Hits 3303 3304 +1
Misses 87 87
Partials 5 5 ☔ View full report in Codecov by Sentry. |
What kind of change does this PR introduce?
Replacement of all hard coded localhost urls in places with environment constant variables.
Issue Number:
Fixes #1244
Did you add tests for your changes?
Snapshots/Videos:
If relevant, did you update the documentation?
Yes
Summary
REACT_ADMIN_FRONTEND_HOST
for two test files to access host IP and port separately and wrote a prompt for it in setup/src/components/AddOn/support/services/Plugin.helper.ts
as I was informed it is outdated and no longer usedDoes this PR introduce a breaking change?
Other information
Have you read the contributing guide?
Yes