-
-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added editorconfig #1492
feat: added editorconfig #1492
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1492 +/- ##
========================================
Coverage 97.29% 97.29%
========================================
Files 133 133
Lines 3396 3396
Branches 1038 1038
========================================
Hits 3304 3304
Misses 87 87
Partials 5 5 ☔ View full report in Codecov by Sentry. |
@noman2002 @anwersayeed Can you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge your code with the latest upstream. The failing tests should pass
a650fc7
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
This pull request introduces a feature of an updated EditorConfig file. The EditorConfig file is a configuration file that helps maintain consistent coding styles across different editors and IDEs used in the project. By defining indentation styles, line endings, and whitespace conventions, the EditorConfig ensures that all developers working on the project follow the same coding standards.
In this update, I have refined the indentation styles and sizes specifically for TypeScript, JavaScript, JSX, and React files. The configuration enforces the use of spaces for indentation with an indent size of 2 spaces for TypeScript and JavaScript files. For JSX and React files, the same configuration is applied, ensuring a consistent coding style throughout the project.
Additionally, the EditorConfig file sets the line endings to Unix-style (LF), specifies the character encoding as UTF-8, and enforces whitespace conventions by trimming trailing whitespaces and inserting a final newline at the end of each file.
This feature contributes to code consistency, readability, and collaboration among developers by providing a standardized configuration for code formatting.
Issue Number:
Fixes #1471
Did you add tests for your changes?
No
Snapshots/Videos:
If relevant, did you update the documentation?
No
Summary
This pull request updates the EditorConfig file to enforce consistent coding styles and whitespace conventions across the project. It aligns with the organization's coding standards.
Does this PR introduce a breaking change?
No
Other information
None
Have you read the contributing guide?
Yes