-
-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the CRUD screens for organizations, for implementation of Address param from Location. #1490
Updated the CRUD screens for organizations, for implementation of Address param from Location. #1490
Conversation
…ated userTableItmes, and tests
…s in utils folder
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
@palisadoes Respected sir, I have created both the PR'S for the ADMIN portal, and the Updated PR for the Talawa-API simultaneously as previously discussed. Both the PR'S must be merged together for the successful implementation of the feature. Thank You. |
@Anubhav-2003 Please fix the failing tests, or document here why the failed tests are acceptable. Do not worry about the introspection test failing. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1490 +/- ##
===========================================
- Coverage 97.29% 97.10% -0.19%
===========================================
Files 133 133
Lines 3396 3418 +22
Branches 1038 1041 +3
===========================================
+ Hits 3304 3319 +15
- Misses 87 94 +7
Partials 5 5 ☔ View full report in Codecov by Sentry. |
@Anubhav-2003 Please fix the failing codecov tests. |
@Cioppolo14 @palisadoes Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks fine but in the last screenshot are 2 location icons, there should be only one. And Also please explain what is sorting code?
Also fix the failing tests. Introspection needs to pass. You have added coffee that is causing it to fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please fix the failing tests. 1. Introspection needs to pass. You have added code that is causing it to fail
83b1234
into
PalisadoesFoundation:develop
Respected sir, Actually some places have sorting codes, but it is optional, and not mandatory. Thank You. |
What kind of change does this PR introduce?
A feature
Issue Number:
#1457
Did you add tests for your changes?
Yes
Snapshots/Videos:
If relevant, did you update the documentation?
No.
Summary
This PR changes the CRUD screens for the organizations in the admin portal, to successfully implement the migration from location param to address in the Talawa-API.
Does this PR introduce a breaking change?
Yes. This PR must be merged along with the PR for the Talawa-API.
Other information
Have you read the contributing guide?
Yes