Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the CRUD screens for organizations, for implementation of Address param from Location. #1490

Merged
merged 19 commits into from
Jan 27, 2024

Conversation

Anubhav-2003
Copy link

What kind of change does this PR introduce?
A feature

Issue Number:
#1457

Did you add tests for your changes?
Yes

Snapshots/Videos:
Screenshot from 2024-01-24 18-43-37
Screenshot from 2024-01-23 19-18-06
Screenshot from 2024-01-23 18-54-21
Screenshot from 2024-01-23 18-42-52
Screenshot from 2024-01-23 14-18-24
Screenshot from 2024-01-23 14-18-00

If relevant, did you update the documentation?
No.

Summary

This PR changes the CRUD screens for the organizations in the admin portal, to successfully implement the migration from location param to address in the Talawa-API.

Does this PR introduce a breaking change?
Yes. This PR must be merged along with the PR for the Talawa-API.

Other information

Have you read the contributing guide?
Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

@Anubhav-2003
Copy link
Author

@palisadoes Respected sir, I have created both the PR'S for the ADMIN portal, and the Updated PR for the Talawa-API simultaneously as previously discussed. Both the PR'S must be merged together for the successful implementation of the feature.

Thank You.

@Cioppolo14
Copy link

@Anubhav-2003 Please fix the failing tests, or document here why the failed tests are acceptable. Do not worry about the introspection test failing.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (378248d) 97.29% compared to head (50db78b) 97.10%.
Report is 2 commits behind head on develop.

Files Patch % Lines
src/components/OrgUpdate/OrgUpdate.tsx 92.30% 1 Missing ⚠️
src/screens/OrgList/OrganizationModal.tsx 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1490      +/-   ##
===========================================
- Coverage    97.29%   97.10%   -0.19%     
===========================================
  Files          133      133              
  Lines         3396     3418      +22     
  Branches      1038     1041       +3     
===========================================
+ Hits          3304     3319      +15     
- Misses          87       94       +7     
  Partials         5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cioppolo14
Copy link

@Anubhav-2003 Please fix the failing codecov tests.

@Anubhav-2003
Copy link
Author

@Cioppolo14 @palisadoes
Respected Ma'am/sir,
Please review, I think the PR is good to merge.

Thank you.

Copy link
Member

@noman2002 noman2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks fine but in the last screenshot are 2 location icons, there should be only one. And Also please explain what is sorting code?

@palisadoes
Copy link
Contributor

Also fix the failing tests. Introspection needs to pass. You have added coffee that is causing it to fail

Copy link
Contributor

@palisadoes palisadoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please fix the failing tests. 1. Introspection needs to pass. You have added code that is causing it to fail

@palisadoes palisadoes merged commit 83b1234 into PalisadoesFoundation:develop Jan 27, 2024
8 of 10 checks passed
@Anubhav-2003
Copy link
Author

Changes looks fine but in the last screenshot are 2 location icons, there should be only one. And Also please explain what is sorting code?

Respected sir, Actually some places have sorting codes, but it is optional, and not mandatory. Thank You.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants