Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setup script for .env configuration file #1461

Merged
merged 5 commits into from
Jan 20, 2024

Conversation

disha1202
Copy link

What kind of change does this PR introduce?

Issue Number:

Fixes #1233

Did you add tests for your changes?

Snapshots/Videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide?

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@disha1202
Copy link
Author

@palisadoes

Please take a look at this PR.

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (45920a7) 97.39% compared to head (6c7f6a1) 97.20%.
Report is 3 commits behind head on develop.

❗ Current head 6c7f6a1 differs from pull request most recent head f4eed45. Consider uploading reports for the commit f4eed45 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1461      +/-   ##
===========================================
- Coverage    97.39%   97.20%   -0.19%     
===========================================
  Files          143      133      -10     
  Lines         3640     3396     -244     
  Branches      1073     1038      -35     
===========================================
- Hits          3545     3301     -244     
  Misses          90       90              
  Partials         5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@disha1202
Copy link
Author

@palisadoes

Please refer to this comment #1459 (comment)

Copy link
Contributor

@palisadoes palisadoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

setup.ts Outdated Show resolved Hide resolved
@palisadoes
Copy link
Contributor

  1. This has not been happening with other PRs
  2. The push workflow only applies when changes are made to the repo branches. PRs don't apply
  3. It's also strange that the github actions are not being triggered.

Please make the suggested changes and let's get this PR merged.

@palisadoes palisadoes merged commit 97994b9 into PalisadoesFoundation:develop Jan 20, 2024
@palisadoes
Copy link
Contributor

The reason for the files being submitted was that you hadn't synced your branch with the latest upstream that had applied all those changes already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants