-
-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing day view in calendar of event screen for both admin and user portal #1447
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
can you change the calendar lines to gray that is used in the code and not black? and how does it looks in the mobile view? @karthxk07 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1447 +/- ##
===========================================
+ Coverage 96.23% 96.49% +0.25%
===========================================
Files 133 134 +1
Lines 3404 3511 +107
Branches 1031 1090 +59
===========================================
+ Hits 3276 3388 +112
+ Misses 123 118 -5
Partials 5 5 ☔ View full report in Codecov by Sentry. |
@aashimawadhwa I have changed the borders to gray and pushed the commit Screencast.from.2024-01-19.16-55-02.webm |
I have few more remarks for the UI changes, if you could implement those too?
Note: please try to replicate design from goggle calendar. we are really working on fine details for UI along with functionalities. |
@aashimawadhwa Ok, I will be working on that |
@karthxk07 Please write the tests for the lines you have added, its dropping significantly. |
@noman2002 ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please write the test for the lines you have added and get the coverage of modified lines to 100%.
@noman2002 i am almost done with the changes , i just need to add all the tests. I will push the commits |
@aashimawadhwa I am done adding the requested changes. Does this look fine? Screencast.from.2024-01-28.12-19-48.webm@noman2002 I will start working on adding the test for uncovered lines now |
@noman2002 I have completed adding the tests too , |
Please fix the failing tests
|
@palisadoes working on it sir 👍
|
Please fix the failing tests
|
@palisadoes Sir added tests for uncovered lines |
Please fix the introspection error. New API code was pushed and Admin needs to be in sync. |
@palisadoes Sir , I am not sure why the error is occurring. The new graphql schema does not contain any requirement of UserToReturn type, which is the cause for the error. The new commits to the api repo have fixed this but i am not sure why this error is still occurring. On my local system the files validate properly. |
Reimport the API data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
95d4869
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
Feature , Implements day view in calendar of event screen for both admin and user portal.
Issue Number:
Fixes #1422
Did you add tests for your changes?
No. No new file added, tests already present.
Snapshots/Videos:
Screencast.from.2024-01-18.20-39-24.webm
If relevant, did you update the documentation?
No, no documentation needed.
Summary
To fulfill the need for a multi-calendar view in both the admin and user portals, necessitating a solution to enhance the calendar functionality.
Implemented a day view for the calendar, similar to the layout observed in Google Calendar. This would involve displaying events on a daily basis for improved user experience and functionality.
Does this PR introduce a breaking change?
No, this PR does not introduce breaking changes
Have you read the contributing guide?
Yes