Feature: Allow Single Object Upload Photo/video #1444
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
|
Please fix the failing tests. |
|
|
|
The introspection test will fail as we have added features to the API that are not yet implemented in Admin Please review |
|
@noman2002 @beingnoble03 can you review it as this feature is was implemented a month ago in previous PR #1193 |
| )} | ||
| {!postformState.postImage && ( | ||
| <> | ||
| <Form.Label htmlFor="postvideo">{t('video')}</Form.Label> |
There was a problem hiding this comment.
I think you can delete video from en.json and other files too. If it's not in use anywhere else in this component/screen.
| @@ -382,116 +397,54 @@ function orgPost(): JSX.Element { | |||
| }); | |||
| }} | |||
| /> | |||
| {!postformState.postVideo && ( | |||
| <> | |||
| <Form.Label htmlFor="postPhoto">{t('image')}</Form.Label> | |||
There was a problem hiding this comment.
I think you can delete image from en.json and other files too. If it's not in use anywhere else in this component/screen.
Co-authored-by: Noble Mittal <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1444 +/- ##
===========================================
- Coverage 97.10% 97.09% -0.02%
===========================================
Files 133 133
Lines 3422 3403 -19
Branches 1041 1031 -10
===========================================
- Hits 3323 3304 -19
Misses 94 94
Partials 5 5 ☔ View full report in Codecov by Sentry. |
|
@beingnoble03 changes done !! |
|
i have done changes can we merge it @palisadoes @beingnoble03 @noman2002 |
palisadoes
merged commit e398810
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
Feature
Issue Number:
Fixes #1127
Did you add tests for your changes?
Yes
Snapshots/Videos:
All the videos and snapshots are present in this pr
#1193
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information
Have you read the contributing guide?