Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: uncaught runtime error #1434

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Bug fix: uncaught runtime error #1434

merged 1 commit into from
Jan 16, 2024

Conversation

DecodeAndCode
Copy link

What kind of change does this PR introduce?

Bug Fix : Due to wrong port number uncaught runtime error was coming which was unable to fetch the data in first time for the solution I have replaced the port no. from 3005 to 3000.

Issue Number:

Fixes #1369

Did you add tests for your changes?

No

Snapshots/Videos:

Screen.Recording.2024-01-15.at.10.18.56.PM.mov

If relevant, did you update the documentation?

No

Summary

Does this PR introduce a breaking change?

No

Other information

Have you read the contributing guide?

Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

@palisadoes
Copy link
Contributor

@SiddheshKukade Please review this is related to plugins

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (655b6b3) 92.77% compared to head (8ee4ac0) 97.34%.
Report is 101 commits behind head on develop.

Files Patch % Lines
...rgProfileFieldSettings/OrgProfileFieldSettings.tsx 90.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1434      +/-   ##
===========================================
+ Coverage    92.77%   97.34%   +4.56%     
===========================================
  Files          134      136       +2     
  Lines         3238     3572     +334     
  Branches       904     1039     +135     
===========================================
+ Hits          3004     3477     +473     
+ Misses         225       90     -135     
+ Partials         9        5       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SiddheshKukade SiddheshKukade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Are you sure that nothing else was running on port 3000 at that time. because I don't think this file being used anywhere

@palisadoes palisadoes merged commit 84c6697 into PalisadoesFoundation:develop Jan 16, 2024
8 of 9 checks passed
@DecodeAndCode
Copy link
Author

DecodeAndCode commented Jan 16, 2024

@SiddheshKukade yes I am pretty sure and in the same file pulgin.helper.ts this function is using this port no. 3005 that can lead to uncaught runtime error in some other scenario. Specify this function :

fetchInstalled = async (): Promise => {
const result = await fetch(http://localhost:3005/installed);
return await result.json();
};

can you look at it??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants