-
-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix: uncaught runtime error #1434
Bug fix: uncaught runtime error #1434
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
@SiddheshKukade Please review this is related to plugins |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1434 +/- ##
===========================================
+ Coverage 92.77% 97.34% +4.56%
===========================================
Files 134 136 +2
Lines 3238 3572 +334
Branches 904 1039 +135
===========================================
+ Hits 3004 3477 +473
+ Misses 225 90 -135
+ Partials 9 5 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Are you sure that nothing else was running on port 3000 at that time. because I don't think this file being used anywhere
84c6697
into
PalisadoesFoundation:develop
@SiddheshKukade yes I am pretty sure and in the same file pulgin.helper.ts this function is using this port no. 3005 that can lead to uncaught runtime error in some other scenario. Specify this function : fetchInstalled = async (): Promise => { can you look at it?? |
What kind of change does this PR introduce?
Bug Fix : Due to wrong port number uncaught runtime error was coming which was unable to fetch the data in first time for the solution I have replaced the port no. from 3005 to 3000.
Issue Number:
Fixes #1369
Did you add tests for your changes?
No
Snapshots/Videos:
Screen.Recording.2024-01-15.at.10.18.56.PM.mov
If relevant, did you update the documentation?
No
Summary
Does this PR introduce a breaking change?
No
Other information
Have you read the contributing guide?
Yes