Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Sidebar and ensuring correct behaviour of event and members in Navbar #1394

Merged
merged 5 commits into from
Jan 7, 2024

Conversation

adi790uu
Copy link
Contributor

@adi790uu adi790uu commented Jan 6, 2024

What kind of change does this PR introduce?

The PR introduces UI changes.

Issue Number:

Fixes #1199

Did you add tests for your changes?

No

Snapshots/Videos:

Screen.Recording.2024-01-07.at.2.11.08.AM.mov

If relevant, did you update the documentation?

No

Summary

It removes the rightbar in user portal and checks the functionality of event and members in Navbar for different organizations.

Does this PR introduce a breaking change?

No

Have you read the contributing guide?

Yes

Copy link

github-actions bot commented Jan 6, 2024

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ee31524) 97.44% compared to head (7f59faa) 97.44%.
Report is 1 commits behind head on develop.

❗ Current head 7f59faa differs from pull request most recent head df4e6bd. Consider uploading reports for the commit df4e6bd to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1394   +/-   ##
========================================
  Coverage    97.44%   97.44%           
========================================
  Files          138      138           
  Lines         3683     3683           
  Branches      1076     1076           
========================================
  Hits          3589     3589           
  Misses          89       89           
  Partials         5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palisadoes palisadoes merged commit 628b3f5 into PalisadoesFoundation:develop Jan 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants