-
-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the profile picture rendering on the Event dashboard. #1382
Fixed the profile picture rendering on the Event dashboard. #1382
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
@AmitSharma512 upload a profile picture of user and attach a screenshot whether the uploaded user image is being shown or not in Left Drawer |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1382 +/- ##
========================================
Coverage 97.44% 97.44%
========================================
Files 138 138
Lines 3683 3683
Branches 1076 1076
========================================
Hits 3589 3589
Misses 89 89
Partials 5 5 ☔ View full report in Codecov by Sentry. |
@rishav-jha-mech |
… into Profile-picture
… into Profile-picture
… into Profile-picture
… into Profile-picture
… into Profile-picture
… into Profile-picture
… into Profile-picture
@rishav-jha-mech, I have made all the required changes; please merge the PR. |
… into Profile-picture
LGTM |
What kind of change does this PR introduce?
Now, the Profile picture is rendered on the Event Dashboard page.
Issue Number:
Fixes #1267
Snapshots/Videos:
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes