Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed hard-codes localhost #1379

Closed
wants to merge 0 commits into from
Closed

fix: fixed hard-codes localhost #1379

wants to merge 0 commits into from

Conversation

1010varun
Copy link

What kind of change does this PR introduce?
this PR will remove all the hard-codes localhost present in source code with the necessary import from .env

Issue Number:

Fixes #1244

Did you add tests for your changes?

No

Snapshots/Videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide?

Copy link

github-actions bot commented Jan 5, 2024

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@1010varun
Copy link
Author

hey @palisadoes,
kindly review my PR.

@palisadoes
Copy link
Contributor

Please fix the failing test

@palisadoes
Copy link
Contributor

palisadoes commented Jan 7, 2024

Please fix the failing tests

@1010varun
Copy link
Author

Hey @palisadoes, I have tested with localhost itself, but it is showing the same error.

@palisadoes
Copy link
Contributor

  1. The failing tests point to a small number of files that are impacted by your change.
  2. Please take a look at them and resolve the failure

@1010varun
Copy link
Author

Hey @palisadoes,
The same test case is failing, runs perfectly on my local env
image

@palisadoes
Copy link
Contributor

  1. Make your local environment match that in our tests to verify operation. You can find details here
  2. Please fix the conflicting files

@palisadoes
Copy link
Contributor

Please work with the assigned reviewers to verify operation, review your code and approve.

@1010varun 1010varun closed this Jan 8, 2024
@palisadoes
Copy link
Contributor

There has been an increasing trend with PRs where they are closed without explanation even when they are made against the develop branch as expected.

This is a real tax on all our time.

  1. The discussion history gets reset with the new PR
  2. We have to find new assigned reviewers
  3. Tracking becomes harder
  4. The reviewers work is easier to get lost.

We have made many warnings about this with little progress.

With immediate effect we will unassign assignees whenever this happens against the develop branch.

I don't want to speculate on the reason, but we cannot let this continue.

@palisadoes palisadoes reopened this Jan 8, 2024
@palisadoes
Copy link
Contributor

@1010varun Are you still working on this?

@1010varun
Copy link
Author

yes sir I am

@1010varun 1010varun closed this Jan 16, 2024
@1010varun
Copy link
Author

I will raise a new PR closing this one.

@palisadoes
Copy link
Contributor

We have a policy of unassigning contributors who close PRs without getting validation from our reviewer team. This is because:

  1. We start looking for people to review PRs when you submit them.
  2. We often contact them and link to the PR. If the PR is closed the whole effort is wasted.
  3. The historical thread of reviewer comments is broken when the work is spread across multiple PRs. The quality of our code is affected negatively.

Please be considerate of our volunteers' limited time and our desire to improve our code base.

This policy is stated as a pinned post in all our Talawa repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants