-
-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed hard-codes localhost #1379
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
hey @palisadoes, |
Please fix the failing test |
Please fix the failing tests |
Hey @palisadoes, I have tested with localhost itself, but it is showing the same error. |
|
Hey @palisadoes, |
|
Please work with the assigned reviewers to verify operation, review your code and approve. |
There has been an increasing trend with PRs where they are closed without explanation even when they are made against the develop branch as expected. This is a real tax on all our time.
We have made many warnings about this with little progress. With immediate effect we will unassign assignees whenever this happens against the develop branch. I don't want to speculate on the reason, but we cannot let this continue. |
@1010varun Are you still working on this? |
yes sir I am |
I will raise a new PR closing this one. |
We have a policy of unassigning contributors who close PRs without getting validation from our reviewer team. This is because:
Please be considerate of our volunteers' limited time and our desire to improve our code base. This policy is stated as a pinned post in all our Talawa repositories. |
What kind of change does this PR introduce?
this PR will remove all the hard-codes localhost present in source code with the necessary import from .env
Issue Number:
Fixes #1244
Did you add tests for your changes?
No
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information
Have you read the contributing guide?