-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added input validation in registration form #1376
feat: added input validation in registration form #1376
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
I created a fresh PR for #1222 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1376 +/- ##
===========================================
+ Coverage 97.22% 97.36% +0.13%
===========================================
Files 137 137
Lines 3429 3680 +251
Branches 964 1076 +112
===========================================
+ Hits 3334 3583 +249
- Misses 90 92 +2
Partials 5 5 ☔ View full report in Codecov by Sentry. |
@rishav-jha-mech |
@MahendraDani since we are not showing the users beforehand what characters must be there while creating a password, you should add these texts in red colour below the password field, which will turn green with a check mark if that param is fulfulled Like this:
When one or more of these params are fulfilled
Showing the user after he is trying to submit the registration form, that their password is incorrect, isn't good from the UX perspective. |
@rishav-jha-mech |
@MahendraDani use mui for icons |
@rishav-jha-mech screen-capture.2.mp4 |
@MahendraDani Good one !, increases the spacing between the first validation text password input field, and reduce the spacing b/w validation texts, also there is too much space b/w the last validation text and confirm password, fix that too then we will do a code review |
@rishav-jha-mech I have improved the spacing between validation checks. screen-capture.3.mp4 |
@rishav-jha-mech @palisadoes |
What kind of change does this PR introduce?
bugfix
Issue Number:
Fixes #1222
Did you add tests for your changes?
No
Snapshots/Videos:
firstname
field is invalidscreen-capture.mp4
lastname
field is invalidscreen-capture.1.mp4
password
field is invalid0a5f6491-12c1-490a-9670-ba414a9e0e37.mp4
If relevant, did you update the documentation?
No
Summary
firstname
,lastname
,email
andpassword
fields in registration formfirstname
andlastname
can contain only lowercase or uppercase letterspassword
should be of atleast 6 characters, it should contain atleast one lowercase letter, one uppercase letter, one numerical value and one special character.Does this PR introduce a breaking change?
No
Other information
Have you read the contributing guide?
Yes