feat: Added pinning functionality in the create post modal #1354
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1354 +/- ##
========================================
Coverage 97.35% 97.35%
========================================
Files 143 143
Lines 3589 3590 +1
Branches 1047 1047
========================================
+ Hits 3494 3495 +1
Misses 90 90
Partials 5 5 ☔ View full report in Codecov by Sentry. |
|
can you please increase padding between the text "pin post" and chose file input field in the create post modal |
|
@aashimawadhwa Done👍
|
| @@ -110,6 +113,7 @@ function orgPost(): JSX.Element { | |||
| text: postinfo, | |||
| organizationId: currentUrl, | |||
| file: postImage || postVideo, | |||
| pinned: pinPost, | |||
| }, | |||
| }); | |||
| /* istanbul ignore next */ | |||
There was a problem hiding this comment.
remove this /* Istanbul ignore next */ comment
There was a problem hiding this comment.
@aashimawadhwa I have removed the comment and the test coverage dropped. To increase the test coverage I was trying to update tests to bring them back to 100%. But every single tests in src/screens/OrgPost/OrgPost.test.tsx which calls CREATE_POST_MUTATION are throwing error after it is called. The test were written exactly before that point where it starts throwing error, that is why they are currently passing.
The error looks like this:
ApolloError: No more mocked responses for the query: mutation CreatePost($text: String!, $title: String!, $organizationId: ID!, $file: String, $pinned: Boolean) { createPost( data: {text: $text, title: $title, organizationId: $organizationId, pinned: $pinned} file: $file ) { _id } } , variables: {"title":"Dummy Post","text":"This is dummy text","file":"","pinned":false}
I have tried many solutions, but nothing is actually worked. Please help.
There was a problem hiding this comment.
@aashimawadhwa Should I comment it out again for now?
There was a problem hiding this comment.
@pateldivyesh1323 yes, please add the comment here.
@aashimawadhwa It just conveys Istanbul to not consider the if branch for code coverage. And, I guess it's not possible to test this branch. We have been using this comment in similar conditions in every other part of the codebase. For now, we can continue having this here.
|
@beingnoble03 Thanks for the review, I have added the comment again. |
palisadoes
merged commit 5e4b1e1
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
Feature: Added pinning functionality to create post modal
Issue Number:
Fixes #1122
Did you add tests for your changes?
Yes
Snapshots/Videos:
Talawa.Posts.-.Google.Chrome.2024-01-02.14-21-43.mp4
If relevant, did you update the documentation?
No
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes