-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Social Icons Integration on Login and Signup Page #1326
Feature: Social Icons Integration on Login and Signup Page #1326
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1326 +/- ##
===========================================
+ Coverage 96.57% 96.99% +0.41%
===========================================
Files 137 137
Lines 3417 3426 +9
Branches 958 963 +5
===========================================
+ Hits 3300 3323 +23
+ Misses 112 98 -14
Partials 5 5 ☔ View full report in Codecov by Sentry. |
Please add the icons similar to the figma file @aialok |
|
Add the slack icon as well and please link the talawa slack to it @aialok |
Sure, should I also add Instagram icon ? |
@aialok you need to add all the social media icons, and they should be colored as given in figma design |
@aashimawadhwa , Please have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment
This is how the Login/Register screen should look like Also you need to add link to the Palisadoes Image (use anchor tag), clicking on which a user can go to the official website of Palisadoes. The icons should be rounded, you can find the updated designs here on this figma link. You can refer to this issue, for the Community Settings, |
|
cinnamon-2024-01-02T153259+0530.webm |
this LGTM now. |
What kind of change does this PR introduce?
Issue Number:
Fixes #1304
Closes #1304
Did you add tests for your changes?
Snapshots/Videos:
cinnamon-2023-12-31T004059+0530.webm
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information
Have you read the contributing guide?