Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Social Icons Integration on Login and Signup Page #1326

Merged

Conversation

aialok
Copy link
Contributor

@aialok aialok commented Dec 30, 2023

What kind of change does this PR introduce?

  • Added Social Icon of The Palisadoes Foundation for given platform.

Issue Number:

Fixes #1304
Closes #1304

Did you add tests for your changes?

  • No

Snapshots/Videos:

cinnamon-2023-12-31T004059+0530.webm

If relevant, did you update the documentation?

Summary

  • Added Social Icon on login and signup page of The Palisadoes Foundation

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide?

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d15cf33) 96.57% compared to head (b18592e) 96.99%.
Report is 9 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1326      +/-   ##
===========================================
+ Coverage    96.57%   96.99%   +0.41%     
===========================================
  Files          137      137              
  Lines         3417     3426       +9     
  Branches       958      963       +5     
===========================================
+ Hits          3300     3323      +23     
+ Misses         112       98      -14     
  Partials         5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aashimawadhwa
Copy link
Member

Please add the icons similar to the figma file @aialok

@aialok
Copy link
Contributor Author

aialok commented Dec 31, 2023

Please add the icons similar to the figma file @aialok

Changes_admin

@aashimawadhwa

  • Making changes that closely resemble the Figma file is a bit challenging. Are the above changes acceptable?

@aashimawadhwa
Copy link
Member

Add the slack icon as well and please link the talawa slack to it @aialok

@aialok
Copy link
Contributor Author

aialok commented Dec 31, 2023

Add the slack icon as well and please link the talawa slack to it @aialok

Sure, should I also add Instagram icon ?

@rishav-jha-mech
Copy link
Contributor

@aialok you need to add all the social media icons, and they should be colored as given in figma design

@aialok
Copy link
Contributor Author

aialok commented Dec 31, 2023

@aashimawadhwa , Please have a look.

Screenshot from 2024-01-01 01-13-51
Screenshot from 2024-01-01 01-13-58

Copy link
Contributor

@palisadoes palisadoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

src/screens/LoginPage/LoginPage.tsx Outdated Show resolved Hide resolved
@rishav-jha-mech
Copy link
Contributor

This is how the Login/Register screen should look like
Home screen _ LOGIN (1)

Also you need to add link to the Palisadoes Image (use anchor tag), clicking on which a user can go to the official website of Palisadoes.

The icons should be rounded, you can find the updated designs here on this figma link.

https://www.figma.com/file/dTGr5CnGHvkilU5nwnRXg2/Talawa-Admin-UI-Redesign?type=design&node-id=307-212&mode=design&t=qXBoOuK57MBGN4QZ-0

You can refer to this issue, for the Community Settings,
#1334

@aialok
Copy link
Contributor Author

aialok commented Jan 2, 2024

  • I have a small suggestion. Since I am using SVGs directly from the Figma design, Can I create a folder named 'social-icons' under the SVGs parent directory and placing all SVGs inside it. This would provide ease of access and reduce potential conflicts for anyone working in the future."
  • In the future, if there is a community that wants to add or delete their own social icons, they can easily do so by adding or deleting from the 'social-icons' folder.

@rishav-jha-mech

@aialok
Copy link
Contributor Author

aialok commented Jan 2, 2024

  • Here is updated social-icon with figma design.
cinnamon-2024-01-02T153259+0530.webm

@aialok aialok requested a review from rishav-jha-mech January 2, 2024 17:35
@aashimawadhwa
Copy link
Member

this LGTM now.

@palisadoes palisadoes merged commit dedd2a6 into PalisadoesFoundation:develop Jan 2, 2024
8 checks passed
@aialok aialok deleted the social-icon-integration branch January 2, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants