-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: added typescript installation guide in INSTALLATION.md #1251
docs: added typescript installation guide in INSTALLATION.md #1251
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1251 +/- ##
========================================
Coverage 96.30% 96.30%
========================================
Files 137 137
Lines 3387 3387
Branches 949 949
========================================
Hits 3262 3262
Misses 119 119
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Please look at the more comprehensive documentation for Talawa-API that explains how to install node and make the appropriate changes at the appropriate locations |
@palisadoes I have following two doubts:
Thanks |
Use what we have in the API guide as inspiration in the Admin guide The Admin guide does not recommend node package managers to use. We need the same here for consistency |
I will do the necessary changes and update the PR by tomorrow. |
@palisadoes I have updated the docs. I have referred to installation guide for If there are any changes please let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment
@palisadoes I have made the necessary changes |
Please fix the conflicting files |
@palisadoes I have resolved merge conflicts and updated this branch with |
What kind of change does this PR introduce?
docs
Issue Number:
Fixes #1243
Did you add tests for your changes?
No
Snapshots/Videos:
NA
If relevant, did you update the documentation?
Summary
INSTALLATION.md
table of content
in the file.Does this PR introduce a breaking change?
Other information
Have you read the contributing guide?