Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed postion of 'All Organizations' button and changed its name #1208

Merged
merged 3 commits into from
Dec 23, 2023

Conversation

adi790uu
Copy link
Contributor

What kind of change does this PR introduce?

This PR renames the "All Organizations" button to "My Organizations" and fixes its postion as specified in the issue.

Issue Number: #1123

Fixes #1123

Did you add tests for your changes?

No

Snapshots/Videos:

ta.mov

If relevant, did you update the documentation?

No

Summary

This pull request addresses the specified issue by renaming the "All Organizations" button to "My Organizations" and adjusting its position to enhance the UI/UX.

Does this PR introduce a breaking change?

No

Have you read the contributing guide?

Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@adi790uu
Copy link
Contributor Author

@noman2002 @aashimawadhwa created this pr for develop branch

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0d50c5d) 95.55% compared to head (c99ac4e) 95.60%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1208      +/-   ##
===========================================
+ Coverage    95.55%   95.60%   +0.05%     
===========================================
  Files          137      137              
  Lines         3330     3346      +16     
  Branches       931      939       +8     
===========================================
+ Hits          3182     3199      +17     
+ Misses         142      141       -1     
  Partials         6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palisadoes
Copy link
Contributor

This screen should say "My Organizations" for consistency. That was one of the goals of creating the issue

image

Copy link
Contributor

@palisadoes palisadoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This screen should say "My Organizations" for consistency. That was one of the goals of creating the issue
  2. The text should already be part of the JSON language translation files. Make sure the text changes according to the language selected. We don't want hard coded text.
  3. You'll need to update the JSON language translation files

image

@adi790uu
Copy link
Contributor Author

@palisadoes in the original issue I had to change the postion of All organization's button and change its name to My organisation which is present in left sidebar and this pr introduces those changes!

@palisadoes
Copy link
Contributor

@palisadoes in the original issue I had to change the postion of All organization's button and change its name to My organisation which is present in left sidebar and this pr introduces those changes!

That may be true, but the overall objective is to have a better UI/UX. By going the extra mile, we achieve that goal. We all want a better product, and you revealed a need that must be addressed

@adi790uu
Copy link
Contributor Author

@palisadoes will fix it for sure and cover all the changes requested!

@aashimawadhwa
Copy link
Member

@adi790uu any updates on this?

@adi790uu
Copy link
Contributor Author

@aashimawadhwa will complete it today

@palisadoes
Copy link
Contributor

Please provide the video that shows that the changes have been implemented, with proof of automatic changing of all the menu items when the language is changed.

@adi790uu
Copy link
Contributor Author

f3bcd311-3ab7-4888-90cb-dcb2dbaa49a9.mp4

@palisadoes

@palisadoes
Copy link
Contributor

@aashimawadhwa @beingnoble03 @rishav-jha-mech please review

Copy link
Member

@aashimawadhwa aashimawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can be merged. we have a different issue that covers test for orglist.tsx rest tests are covered.

@palisadoes palisadoes self-requested a review December 23, 2023 19:46
@palisadoes palisadoes merged commit e52d39e into PalisadoesFoundation:develop Dec 23, 2023
7 checks passed
aialok pushed a commit to aialok/talawa-admin that referenced this pull request Dec 25, 2023
…isadoesFoundation#1208)

* Fixed postion of 'All Organizations' button and changed its name

* Changed 'Organizations' to 'My Organizations' and added translations

* fixed 'My Organizations' icon

---------

Co-authored-by: Aditya Agarwal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants