-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed postion of 'All Organizations' button and changed its name #1208
Fixed postion of 'All Organizations' button and changed its name #1208
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
@noman2002 @aashimawadhwa created this pr for develop branch |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1208 +/- ##
===========================================
+ Coverage 95.55% 95.60% +0.05%
===========================================
Files 137 137
Lines 3330 3346 +16
Branches 931 939 +8
===========================================
+ Hits 3182 3199 +17
+ Misses 142 141 -1
Partials 6 6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This screen should say "My Organizations" for consistency. That was one of the goals of creating the issue
- The text should already be part of the JSON language translation files. Make sure the text changes according to the language selected. We don't want hard coded text.
- You'll need to update the JSON language translation files
@palisadoes in the original issue I had to change the postion of All organization's button and change its name to My organisation which is present in left sidebar and this pr introduces those changes! |
That may be true, but the overall objective is to have a better UI/UX. By going the extra mile, we achieve that goal. We all want a better product, and you revealed a need that must be addressed |
@palisadoes will fix it for sure and cover all the changes requested! |
@adi790uu any updates on this? |
@aashimawadhwa will complete it today |
Please provide the video that shows that the changes have been implemented, with proof of automatic changing of all the menu items when the language is changed. |
f3bcd311-3ab7-4888-90cb-dcb2dbaa49a9.mp4 |
@aashimawadhwa @beingnoble03 @rishav-jha-mech please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can be merged. we have a different issue that covers test for orglist.tsx rest tests are covered.
…isadoesFoundation#1208) * Fixed postion of 'All Organizations' button and changed its name * Changed 'Organizations' to 'My Organizations' and added translations * fixed 'My Organizations' icon --------- Co-authored-by: Aditya Agarwal <[email protected]>
What kind of change does this PR introduce?
This PR renames the "All Organizations" button to "My Organizations" and fixes its postion as specified in the issue.
Issue Number: #1123
Fixes #1123
Did you add tests for your changes?
No
Snapshots/Videos:
ta.mov
If relevant, did you update the documentation?
No
Summary
This pull request addresses the specified issue by renaming the "All Organizations" button to "My Organizations" and adjusting its position to enhance the UI/UX.
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes