Skip to content

Commit

Permalink
Node upgrade (#1309)
Browse files Browse the repository at this point in the history
* upgraded workflows to use node v20

* deleted IDE yml files
  • Loading branch information
Veer0x1 authored Dec 27, 2023
1 parent ea6aa0b commit a7e4663
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pull-requests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v3
with:
node-version: '16.14.1'
node-version: '20.x'

- name: resolve dependency
run: npm install -g @graphql-inspector/cli
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ env:
jobs:
Code-Coverage:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [20.x]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
Expand Down
2 changes: 1 addition & 1 deletion INSTALLATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ cd talawa-admin

## Setting up NPM

If you've followed the previous steps you should have already set up node.js on your system. [Click here](https://docs.npmjs.com/downloading-and-installing-node-js-and-npm) for the official setup guide for npm.
If you've followed the previous steps you should have already set up node.js (v20 LTS) on your system. [Click here](https://docs.npmjs.com/downloading-and-installing-node-js-and-npm) for the official setup guide for npm.

## Installing required packages/dependencies

Expand Down
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -127,5 +127,8 @@
"@types/react": "17.0.2",
"@types/react-dom": "17.0.2",
"graphql": "^16.5.0"
},
"engines": {
"node": ">=20.x"
}
}

0 comments on commit a7e4663

Please sign in to comment.