Skip to content

Commit

Permalink
implemented requested changes to exposed ports and node version for d…
Browse files Browse the repository at this point in the history
…ockerfiles
  • Loading branch information
Devesh326 committed Jan 26, 2024
1 parent b9aaff0 commit 83f363d
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 8 deletions.
3 changes: 2 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
# Contains the PDF file of the Tag as JSON string, thus does not need to be linted
src/components/CheckIn/tagTemplate.ts
src/components/CheckIn/tagTemplate.ts
docker-compose.yml
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:20-alpine
FROM node:lts

WORKDIR /usr/src/app

Expand All @@ -8,6 +8,6 @@ RUN npm install --legacy-peer-deps

COPY . .

EXPOSE 3000
EXPOSE $PORT

CMD ["npm", "run", "serve"]
8 changes: 4 additions & 4 deletions INSTALLATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ This document provides instructions on how to set up and start a running instanc
- [Setting up this repository](#setting-up-this-repository)
- [Setting up npm](#setting-up-npm)
- [Setting up Typescript](#setting-up-typescript)
- [Installation With Docker](#installation-using-docker)
- [Installation Using Docker](#installation-using-docker)
- [Installing required packages/dependencies](#installing-required-packagesdependencies)
- [Configuration](#configuration)
- [Creating .env file](#creating-env-file)
Expand All @@ -20,7 +20,7 @@ This document provides instructions on how to set up and start a running instanc
- [Setting up REACT_APP_RECAPTCHA_SITE_KEY in .env file](#setting-up-react_app_recaptcha_site_key-in-env-file)
- [Setting up Compiletime and Runtime logs](#setting-up-compiletime-and-runtime-logs)
- [Post Configuration Steps](#post-configuration-steps)
- [Running Talawa-Admin](#running-talawa-admin)
- [Running Talawa-Admin without Docker](#running-talawa-admin-without-docker)
- [Accessing Talawa-Admin](#accessing-talawa-admin)
- [Talawa-Admin Registration](#talawa-admin-registration)
- [Talawa-Admin Login](#talawa-admin-login)
Expand All @@ -29,8 +29,8 @@ This document provides instructions on how to set up and start a running instanc
- [Debugging tests](#debugging-tests)
- [Linting code files](#linting-code-files)
- [Husky for Git Hooks](#husky-for-git-hooks)
- [pre-commit hook](#pre-commit-hook)
- [post-merge hook](#post-merge-hook)
- [pre-commit hook](#pre-commit-hook)
- [post-merge hook](#post-merge-hook)

<!-- tocstop -->

Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ services:
volumes:
- .:/usr/src/app
ports:
- '3000:3000'
- $PORT:$PORT

0 comments on commit 83f363d

Please sign in to comment.