Skip to content

Commit

Permalink
Update pull-request-target.yml
Browse files Browse the repository at this point in the history
  • Loading branch information
palisadoes authored Nov 25, 2024
1 parent ff25183 commit 7d2f235
Showing 1 changed file with 14 additions and 11 deletions.
25 changes: 14 additions & 11 deletions .github/workflows/pull-request-target.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,21 @@ jobs:
comment-tag: pr_review_policy
message: |
## Our Pull Request Approval Process
We have these basic policies to make the approval process smoother for our volunteer team.
Thanks for contributing!
### Testing Your Code
Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
1. The overall code coverage drops below the target threshold of the repository
2. Any file in the pull request has code coverage levels below the repository threshold
3. Merge conflicts
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.
Remember, your PRs won't be reviewed until these criteria are met:
1. We don't merge PRs with poor code quality.
1. Follow coding best practices such that CodeRabbit.ai approves your PR.
1. We don't merge PRs with failed tests.
1. When tests fail, click on the `Details` link to learn more.
1. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
1. Tests may fail if you edit sensitive files. Ask to add the `sensitive-files-ignore-pr` label if the edits are necessary.
These policies make our code better.
### Reviewers
Expand Down

0 comments on commit 7d2f235

Please sign in to comment.