Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【CMake opt No.2】rm some DEPS of test/cpp/auto_parallel/CMakeLists.txt #60348

Merged
merged 5 commits into from
Dec 29, 2023

Conversation

zade23
Copy link
Contributor

@zade23 zade23 commented Dec 26, 2023

PR types

Others

PR changes

Others

Description

任务来源:#60013

#60274 解决冲突问题后重新提交

Copy link

paddle-bot bot commented Dec 26, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

risemeup1
risemeup1 previously approved these changes Dec 26, 2023
@luotao1
Copy link
Contributor

luotao1 commented Dec 28, 2023

@zade23 需要过一下流水线

@zade23
Copy link
Contributor Author

zade23 commented Dec 28, 2023

@zade23 需要过一下流水线

@luotao1 好的,我检查一下

spmd_rule_test_util
spmd_rules
phi)
paddle_test(spmd_rule_test SRCS spmd_rule_test.cc)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
paddle_test(spmd_rule_test SRCS spmd_rule_test.cc)
paddle_test(spmd_rule_test SRCS spmd_rule_test.cc DEPS spmd_rule_test_util)

spmd_rule_test_util
spmd_rules
phi)
paddle_test(softmax_grad_spmd_rule_test SRCS softmax_grad_spmd_rule_test.cc)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
paddle_test(softmax_grad_spmd_rule_test SRCS softmax_grad_spmd_rule_test.cc)
paddle_test(softmax_grad_spmd_rule_test SRCS softmax_grad_spmd_rule_test.cc DEPS spmd_rule_test_util)

spmd_rule_test_util
spmd_rules
phi)
paddle_test(tile_spmd_rule_test SRCS tile_spmd_rule_test.cc)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
paddle_test(tile_spmd_rule_test SRCS tile_spmd_rule_test.cc)
paddle_test(tile_spmd_rule_test SRCS tile_spmd_rule_test.cc DEPS spmd_rule_test_util)

paddle_test(tile_spmd_rule_test SRCS tile_spmd_rule_test.cc)

paddle_test(fused_linear_param_grad_add_spmd_rule_test SRCS
fused_linear_param_grad_add_spmd_rule_test.cc)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fused_linear_param_grad_add_spmd_rule_test.cc)
fused_linear_param_grad_add_spmd_rule_test.cc DEPS spmd_rule_test_util)

fused_linear_param_grad_add_spmd_rule_test.cc)

paddle_test(cross_entropy_softmax_spmd_rule_test SRCS
cross_entropy_softmax_spmd_rule_test.cc)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cross_entropy_softmax_spmd_rule_test.cc)
cross_entropy_softmax_spmd_rule_test.cc DEPS spmd_rule_test_util)

Copy link
Contributor Author

@zade23 zade23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

从CI的log看,可能是 DEPSspmd_rule_test_util 不能删除,修改后重新运行CI再看一遍结果

@risemeup1 risemeup1 merged commit 4cb084c into PaddlePaddle:develop Dec 29, 2023
29 checks passed
@zade23 zade23 deleted the cmake_02 branch December 29, 2023 02:29
Wanglongzhi2001 pushed a commit to Wanglongzhi2001/Paddle that referenced this pull request Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants