Support code generation for op multiclass_nms3 #54272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
应该在生成阶段出的问题，我待会试着修一下
|
…togen_multiclass_nms3
…i/Paddle into autogen_multiclass_nms3
huangjiyi
commented
Jun 4, 2023
Comment on lines
1469
to
1478
| # Get return type list & outputs | ||
| returns_type_list = ["" for i in range(num_outputs)] | ||
| returns_list = ["" for i in range(num_outputs)] | ||
| num_visited_intermediate_outputs = 0 | ||
| for name, (rtype, pos) in forward_outputs_position_map.items(): | ||
| if name in intermediate_outputs: | ||
| num_visited_intermediate_outputs += 1 | ||
| continue | ||
| pos -= num_visited_intermediate_outputs | ||
| returns_list[pos] = f"{name}" |
There was a problem hiding this comment.
上面的问题是因为 eager_gen.py 在解析返回值列表的代码中，没有考虑到 intermediate 类型的 output 不在 outputs List 最后的情况，已修复
There was a problem hiding this comment.
将 index 的 intermediate 移除后，这段改动还需要吗？
There was a problem hiding this comment.
将 index 的 intermediate 移除后，这段改动还需要吗？
目前就先将index的intermediate 去除。这里的改动先保留，确实存在逻辑问题。
…i/Paddle into autogen_multiclass_nms3
class MultiClassNMS2OpMaker : public MultiClassNMSOpMaker {
public:
void Make() override {
MultiClassNMSOpMaker::Make();
AddOutput("Index",
"(phi::DenseTensor) A 2-D phi::DenseTensor with shape [No, 1] "
"represents the "
"index of selected bbox. The index is the absolute index cross "
"batches.")
.AsIntermediate();
}
};
output, index, nms_rois_num = _C_ops.multiclass_nms3(
bboxes, scores, rois_num, *attrs
)然后跑单测会出现下面的错误：
|
|
@heavyrain-lzy，帮忙 Review 一下～ |
|
@luotao1，帮忙豁免一下 CI ~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description