Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CalculatorTool ACE vulnerability #301

Merged
merged 6 commits into from
May 31, 2024

Conversation

Bobholamovic
Copy link
Member

修复CalculatorTool任意代码执行漏洞。

@@ -6,7 +6,7 @@
from typing import Any, Dict, List, Union

import jsonlines
import markdown # type: ignore
import markdown # type: ignore[import-untyped]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

顺带为部分type: ignore注释标注了error code,这样可以确保该处ignore type是出于特定的原因。

Copy link
Collaborator

@sijunhe sijunhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sijunhe sijunhe merged commit 0f87d06 into PaddlePaddle:develop May 31, 2024
5 checks passed
@Bobholamovic Bobholamovic deleted the agent/fix/calculator_ace branch May 31, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants