[Enhancement]Add clarify #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Southpika
commented
Jan 10, 2024
•
Southpika
commented
- cha t_model增加human clarify接口：当用户问题填参不清晰时询问用户
|
在response中增加clarify，同时增加noaction返回信息 |
sijunhe
reviewed
Jan 11, 2024
| pass | ||
|
|
||
|
|
||
| @dataclass | ||
| class NoActionStep(AgentStep[_NullInfo, _NullResult]): | ||
| class NoActionStep(AgentStep[EndInfo, NullResult]): |
There was a problem hiding this comment.
我又思考了一下，有一些不同看法：现在NoActionStep可能已经不是简单的sentinel了。不过，NoActionStep在定位上其实并不一定与end强绑定（只是FunctionAgent正好遇到NoActionStep终止）。为了提升自由度，建议NoActionStep的_IT设置为Dict[str, Any]、_RT设置为Any，允许自由配置。在FunctionAgent中可以通过NoActionStep传递end_reason信息。
NO_ACTION_STEP仍然可以提供，建议直接NoActionStep(info={}, result=None)，用作哨兵。
| @@ -204,20 +206,33 @@ async def _step( | |||
| new_messages, | |||
| ) | |||
| else: | |||
| if output_message.clarify: | |||
| # `clarify` and [`function_call`, `plugin`(directly end)] will not appear at the same time | |||
| return NoActionStep(info=EndInfo(end_reason="CLARIFY"), result=NullResult()), new_messages | |||
| return NO_ACTION_STEP, new_messages | |||
|
|
|||
| def _create_finished_response( | |||
There was a problem hiding this comment.
这里其实不一定是创建finished response了，这个方法名字需要修改吗？
|
已修改为使用EndStep做为统一的结束信号 |
Bobholamovic
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.