[Tool Test] Add test for tools #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wj-Mcat
commented
Jan 8, 2024
| @@ -3,3 +3,6 @@ pytest == 7.4.2 | |||
| pytest-asyncio | |||
| pytest-cov | |||
| uvicorn | |||
| pymupdf | |||
There was a problem hiding this comment.
ScraperTool 的有依赖这几个
| @@ -36,11 +36,11 @@ def avaliable_free_port(self, exclude=None): | |||
| raise ValueError("can not get valiable port in [8000, 8200]") | |||
|
|
|||
| def setUp(self) -> None: | |||
| from multiprocessing import Process | |||
| from threading import Thread | |||
There was a problem hiding this comment.
用线程额方式来测试，否则单测覆盖率检测不到子进程中的代码覆盖情况
wj-Mcat
commented
Jan 8, 2024
|
|
||
| class Config: | ||
| use_enum_values = True | ||
| model_config = ConfigDict(use_enum_values=True) |
There was a problem hiding this comment.
pydantic 2.0 里面已经不推荐 config-class base 的配置方法，所以调整了。
sijunhe
reviewed
Jan 9, 2024
Comment on lines
+16
to
+17
| from langchain_community.document_loaders import PyMuPDFLoader | ||
| from langchain_community.retrievers import ArxivRetriever |
There was a problem hiding this comment.
这个应该是比较近期的改动。需要在我们的requirements.txt里面加入对于langchain >= 拆分后的版本吗？
| check_json_length(fake_json_data) | ||
|
|
||
|
|
||
| def test_tool_string_format(): |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #273 +/- ##
===========================================
+ Coverage 69.37% 72.15% +2.78%
===========================================
Files 63 63
Lines 3236 3229 -7
===========================================
+ Hits 2245 2330 +85
+ Misses 991 899 -92 ☔ View full report in Codecov by Sentry. |
sijunhe
approved these changes
Jan 10, 2024
Comment on lines
22
to
23
| print(cur_time) | ||
| print(tool) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.