Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]Update system message #272

Merged
merged 19 commits into from
Jan 10, 2024

Conversation

shiyutang
Copy link
Collaborator

@shiyutang shiyutang commented Jan 8, 2024

  • 增加system message 在memory.get_message中展示。
  • 同步agent中设置的system message到memory。
  • 后续不再通过memory设置system message,只保留agent中同步入口。

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6fbc099) 69.37% compared to head (c0c5446) 69.64%.

Files Patch % Lines
erniebot-agent/src/erniebot_agent/agents/agent.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #272      +/-   ##
===========================================
+ Coverage    69.37%   69.64%   +0.26%     
===========================================
  Files           63       63              
  Lines         3236     3245       +9     
===========================================
+ Hits          2245     2260      +15     
+ Misses         991      985       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shiyutang shiyutang requested review from Bobholamovic, sijunhe and Southpika and removed request for Bobholamovic January 8, 2024 07:05
@Southpika
Copy link
Contributor

诗雨再拉一次271~给functionagent_with_retrieval 加了一个单测,其他没有意见~

Copy link
Member

@Bobholamovic Bobholamovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可能还需要修改下mock_memory的实现~

@shiyutang
Copy link
Collaborator Author

done~

@sijunhe sijunhe merged commit b55b450 into PaddlePaddle:develop Jan 10, 2024
4 checks passed
@shiyutang shiyutang deleted the update_system branch January 11, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants