Adding missing test, renaming config parameter

Pablissimo · Feb 4, 2017 · 1065a4d · 1065a4d
1 parent 95f6cef
commit 1065a4d
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/src/main/java/com/pablissimo/sonar/TsLintExecutorConfig.java b/src/main/java/com/pablissimo/sonar/TsLintExecutorConfig.java
@@ -31,7 +31,7 @@ public static TsLintExecutorConfig fromSettings(Settings settings, SensorContext
         return toReturn;
     }
 
-    public Boolean useAlreadyExistsTsLintOutput() {
+    public Boolean useExistingTsLintOutput() {
         return this.pathToTsLintOutput != null && !this.pathToTsLintOutput.isEmpty();
     }
 

diff --git a/src/main/java/com/pablissimo/sonar/TsLintExecutorImpl.java b/src/main/java/com/pablissimo/sonar/TsLintExecutorImpl.java
@@ -90,7 +90,7 @@ else if (files == null) {
             throw new IllegalArgumentException("files");
         }
 
-        if (config.useAlreadyExistsTsLintOutput()) {
+        if (config.useExistingTsLintOutput()) {
             LOG.debug("Running with existing JSON file '" + config.getPathToTsLintOutput() + "' instead of calling tslint");
             List<String> toReturn = new ArrayList<String>();
             toReturn.add(this.getFileContent(new File(config.getPathToTsLintOutput())));

diff --git a/src/test/java/com/pablissimo/sonar/TsLintExecutorConfigTest.java b/src/test/java/com/pablissimo/sonar/TsLintExecutorConfigTest.java
@@ -79,6 +79,22 @@ public void useTsConfigInsteadOfFileList_returnsFalse_ifPathToTsConfigNotSet() {
 
         assertFalse(config.useTsConfigInsteadOfFileList());
     }
+
+    @Test
+    public void useExistingTsLintOutput_returnsTrueIfPathSet() {
+        TsLintExecutorConfig config = getNewConfig();
+        config.setPathToTsLintOutput("/path/to/tslint/json/output");
+
+        assertTrue(config.useExistingTsLintOutput());
+    }
+
+    @Test
+    public void useExistingTsLintOutput_returnsFalseIfPathNotSet() {
+        TsLintExecutorConfig config = getNewConfig();
+        config.setPathToTsLintOutput("");
+
+        assertFalse(config.useExistingTsLintOutput());
+    }
 
     @Test
     public void fromSettings_initialisesFromSettingsAndResolver() {