-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows Build #10
Conversation
Fix portability of vector iterator
Fix Windows Check
Import windows for target architecture
Fix casting to HANDLE
There's a minor style issue, otherwise good to merge (https://github.com/PX4/ulog_cpp/actions/runs/10309113259/job/28554831362?pr=10). |
So based on this (https://stackoverflow.com/questions/4845198/fatal-error-no-target-architecture-in-visual-studio) windows.h needs to be included first otherwise I get "No Target Architecture". But maybe we just use a different method to define it, like this?
Probably this wouldn't happen when using this as a submodule, just when using the tests directly. |
Ah ok, then let's just ignore it with |
Fix Lint Error
- Fix portability of vector iterator - Fix casting to HANDLE
- Fix portability of vector iterator - Fix casting to HANDLE
Fixes a couple of windows issues
Edit: CMake should be updated too (like the compile options) but it shouldn't affect using this as a submodule since MAIN_PROJECT would be false