Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogCutter.py #105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

LogCutter.py #105

wants to merge 1 commit into from

Conversation

ryanjAA
Copy link

@ryanjAA ryanjAA commented Oct 12, 2024

Allows you to cut any log and copies the header into, etc into the cut file. has a basic ui in tkinter.

Since I’ve seen this asked for quite a bit, makes sense to make it part of the toolset.

Rename as needed, etc.

Allows you to cut any log and copies the header into, etc into the cut file.  has a basic ui in tkinter. 

Since I’ve seen this asked for quite a bit, makes sense to make it part of the toolset. 

Rename as needed, etc.
Copy link
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the tool makes sense.
For merging, these are the changes I'd like to see:

  • integrate it with the core instead of a separate parser. And then use the write functionality of the core. As it is now, the splitting isn't quite correct, there can be Subscription messages after the first Data message, which means the second split of the log would not contain these Subscription's.
  • remove the UI - this repo should only have CLI tools. We can create a separate package for UI tools.
  • rename to ulog_cut or similar, to be consistent with the other tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants