QGC Parameters #265
QGC Parameters #265
Conversation
|
@bkueng let me know if there is any changes you would like me to make |
|
Thanks Andrew! I appreciate it! |
app/plot_app/templates/header.html
Outdated
| @@ -56,7 +56,9 @@ <h1> | |||
| <div class="dropdown-menu"> | |||
| <a class="dropdown-item" href="download?log={{ log_id }}">Log File</a> | |||
| <a class="dropdown-item" href="download?log={{ log_id }}&type=1" target="_blank">Parameters</a> | |||
There was a problem hiding this comment.
I think we can remove this option (but keep the implementation), and just offer the QGC versions.
app/tornado_handlers/download.py
Outdated
|
|
||
| delimiter = ' ' | ||
| for param_key in param_keys: | ||
| self.write("1") |
There was a problem hiding this comment.
Can you add a comment that this is the sysid (and compid below)?
app/tornado_handlers/download.py
Outdated
| self.write('\n') | ||
| except: | ||
| pass | ||
|
|
||
| else: |
There was a problem hiding this comment.
This else case was part of the elif download_type == '3': # download the non-default parameters case above and needs to be copied up to that case again, and here it needs to be adjusted for the QGC format.
|
Apologies Beat, I did not see you had reviewed this. I will fix these |
|
@bkueng I addressed your comments. I know you mentioned there are some CI problems that we will incur. Mainly the long method. what is the method length that will pass the CICD test so I know how to modify the code? |
|
I needed to approve so the checks are running. They're queued now and should run shortly. This is from a previous run: https://github.com/PX4/flight_review/actions/runs/6726581710/job/18290754736#step:5:14. |
|
@bkueng made changes. Also added something to the bottom of the readme to let others know to run |
When you want to download a parameter file... it can not be directly uploaded into QGC. This givces you the option to download the QGC compatible one. This PR was based off of @farhangnaderi PR here: #264