Bugfix/php8.1 deprecations (#19)

PUGX · Dec 8, 2021 · b517fe4 · b517fe4
1 parent c99ea91
commit b517fe4
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 5 deletions.
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
@@ -36,6 +36,7 @@ jobs:
                     - '7.3'
                     - '7.4'
                     - '8.0'
+                    - '8.1'
                 include:
                     - description: 'lowest'
                       php: '7.1'
@@ -46,8 +47,10 @@ jobs:
                       php: '7.3'
                     - description: '7.4'
                       php: '7.4'
-                    - description: 'latest'
+                    - description: '8.0'
                       php: '8.0'
+                    - description: 'latest'
+                      php: '8.1'
         name: PHP ${{ matrix.php }} tests
         steps:
             - name: Checkout

diff --git a/src/Shortid.php b/src/Shortid.php
@@ -58,10 +58,7 @@ public static function isValid(string $value, int $length = null, string $alphab
         return $ok > 0 && \strlen($matches[0]) === $length;
     }
 
-    /**
-     * @return string
-     */
-    public function jsonSerialize()
+    public function jsonSerialize(): string
     {
         return $this->id;
     }
@@ -78,4 +75,20 @@ public function unserialize($serialized): void
     {
         $this->id = $serialized;
     }
+
+    /**
+     * @return array{id: string}
+     */
+    public function __serialize(): array
+    {
+        return ['id' => $this->id];
+    }
+
+    /**
+     * @param array{id: string} $serialized
+     */
+    public function __unserialize(array $serialized): void
+    {
+        $this->id = $serialized['id'];
+    }
 }
diff --git a/tests/ShortidTest.php b/tests/ShortidTest.php
@@ -98,4 +98,19 @@ public function testUnserialize(): void
 
         $this->assertSame('shortid', (string) $shortid);
     }
+
+    public function testMagicSerialize(): void
+    {
+        $shortid = new Shortid('shortid');
+
+        $this->assertSame(['id' => 'shortid'], $shortid->__serialize());
+    }
+
+    public function testMagicUnserialize(): void
+    {
+        $shortid = Shortid::generate();
+        $shortid->__unserialize(['id' => 'shortid']);
+
+        $this->assertSame('shortid', (string) $shortid);
+    }
 }