Skip to content

Commit

Permalink
Revert "Formally return metadata from _populate_missing_properties"
Browse files Browse the repository at this point in the history
This reverts commit 291579a.
  • Loading branch information
ammopt committed Mar 27, 2024
1 parent 8cd973c commit 58fac6a
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions Koha/Plugin/Com/PTFSEurope/ReprintsDesk/Api.pm
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ sub PlaceOrder2 {

# If the config says we should use borrower properties for deliveryprofile values
# use as many as we can, these should have come in the payload
my ($metadata, $metadata_deliveryprofile_error) = _populate_missing_properties(
my $metadata_deliveryprofile_error = _populate_missing_properties(
$metadata,
$config,
$check_populated_delivery_profile,
Expand Down Expand Up @@ -364,7 +364,7 @@ sub _populate_missing_properties {
} else {

# Neither the borrower or the config have the required value, return for error handling
return ( undef, $metadata_name );
return $metadata_name;
}
}
} else {
Expand All @@ -375,11 +375,10 @@ sub _populate_missing_properties {
} else {

# The config does not have the required value, return for error handling
return ( undef, $metadata_name );
return $metadata_name;
}
}
}
return ( $metadata, undef );
}

sub _make_request {
Expand Down

0 comments on commit 58fac6a

Please sign in to comment.