Handle error if date format is invalid

PTFS-Europe · Oct 30, 2024 · 48d37cf · 48d37cf
1 parent e5bfbc5
commit 48d37cf
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/Koha/Plugin/Com/PTFSEurope/ReprintsDesk/Processor/CheckAvailability.pm b/Koha/Plugin/Com/PTFSEurope/ReprintsDesk/Processor/CheckAvailability.pm
@@ -177,7 +177,7 @@ sub run {
         my $unavailable_request_to_update = Koha::ILL::Requests->find( $unavailable_id->{illrequest_id} );
 
         # Bail if we can't price check
-        if ( !$unavailable_id->{standardnumber} || !$unavailable_id->{year} ) {
+        if ( !$unavailable_id->{standardnumber} || !$unavailable_id->{year} || $unavailable_id->{year} !~ /^\d{4}$/) {
             $self->debug_msg(
                 sprintf(
                     "Request #%d does not have a ISSN/ISBN or year. Skipping this price check.",
@@ -192,6 +192,9 @@ sub run {
             $unavailable_request_to_update->append_to_note(
                 "Request is missing 'year' required for price check." . $note_instructions )
                 unless $unavailable_id->{year};
+            $unavailable_request_to_update->append_to_note(
+                "Request 'year' is not in expected format (YYYY) for price check. " . $note_instructions )
+                unless $unavailable_id->{year} =~ /^\d{4}$/;
             $unavailable_request_to_update->status($status_if_unavailable_without_price);
             next;
         }