Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: error messages are specific #136

Conversation

Chloe070196
Copy link

Requested change: error messages should be more specific


Error messages should narrow down the cause
to whether the pertain to authentication, issues
loading data from EDS, or processing the search,
and do so without risking to expose any data that
should not be made publicly visible.

Test plan:

  • navigate to Aspen Administration > EBSCO EDS > Settings
  • create a new Setting, make sure to use invalid credentials and save
  • navigate to Aspen Administration > Primary Configuration > Library Systems and select your
    current Library
  • set its EDS Setting to the setting you just created
  • log out
  • run a search in Articles and Databases

Before this commit, the error message will
indicate that the EDS search failed. After this,
it will indicate that it failed due to an
EDS authentication issue.

Note: this also removes the possibility for errors thrown during the search processing to be show to
the end user directly - they are logged instead.

Error messages should narrow down the cause
to whether the pertain to authentication, issues
loading data from EDS, or processing the search,
and do so without risking to expose any data that
should not be made publicly visible.

Test plan:

- navigate to Aspen Administration > EBSCO EDS >
Settings
- create a new Setting, make sure to use invalid
credentials and save
- navigate to Aspen Administration > Primary
Configuration > Library Systems and select your
current Library
- set its EDS Setting to the setting you just
created
- log out
- run a search in Articles and Databases

Before this commit, the error message will
indicate that the EDS search failed. After this,
it will indicate that it failed due to an
EDS authentication issue.

Note: this also removes the possibility for errors
thrown during the search processing to be show to
the end user directly - they are logged instead.
@Chloe070196 Chloe070196 merged commit 600bedf into PTFS-Europe:24.10.00_handle_eds_search_error Oct 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant