Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested change: error messages should be more specific
Error messages should narrow down the cause
to whether the pertain to authentication, issues
loading data from EDS, or processing the search,
and do so without risking to expose any data that
should not be made publicly visible.
Test plan:
current Library
Before this commit, the error message will
indicate that the EDS search failed. After this,
it will indicate that it failed due to an
EDS authentication issue.
Note: this also removes the possibility for errors thrown during the search processing to be show to
the end user directly - they are logged instead.