24.10.00 handle eds search error #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an Aspen error is thrown for EBSCO EDS search and the searchError.tpl file is displayed, instead of the original error message, this php error is shown: Cannot use object of type AspenError as array Test plan: - navigate to Aspen Administration > EBSCO EDS > Settings - create a new Setting, make sure to use invalid credentials and save - navigate to Aspen Administration > Primary Configuration > Library Systems and select your current Library - set its EDS Setting to the setting you just created - run a search in Articles and Databases Before this commit: The error message is uninformative (Cannot use object of type AspenError as array). After this commit: The error message refers to a specific cause.
Test plan:
- navigate to Aspen Administration > EBSCO EDS >
Settings
- create a new Setting, make sure to use invalid
credentials and save
- navigate to Aspen Administration > Primary
Configuration > Library Systems and select your
current Library
- set its EDS Setting to the setting you just
created
- log out
- run a search in Articles and Databases
Before this commit:
An error message appears at the top of the screen.
This message contains the information sent back by
EDS.
After this commit:
The error message does not show on screen anymore
and is logged instead.
Chloe070196
force-pushed
the
24.10.00_handle_eds_search_error
branch
from
b9a62d0 to
db9aed0
Compare
Chloe070196
merged commit ccd5969
into
PTFS-Europe:24.10.00_handle_eds_search_error
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDS errors should be logged and not echoed, and a standard Aspen Error should be displayed to the user.
Test plan: see commit messages