24.11.00 grapes js remove edit button #134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Edit button from grapes view as page as the editor can be accessed through the breadcrumbs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://aspen-discovery.atlassian.net/jira/software/c/projects/DIS/issues/DIS-33?jql=project%20%3D%20%22DIS%22%20ORDER%20BY%20created%20DESC
Remove Edit button from grapes view as page as the editor can be accessed through the breadcrumbs and this option is more in keeping with the rest of Aspen.
TEST PLAN:
Ensure Web Builder is enabled System Administration->Modules->Web Builder.
Ensure that Grapes JS is enabled System Administration->System Variables-> Enable Grapes Editor
Prior to applying patch:
Navigate to Web Builder->Grapes Pages and select Add new.
Create a page and click Open in Editor.
Add some content using Grapes JS.
Ensure you save the page.
Navigate back to the list of pages using the breadcrumbs at the top of the editor. Click view as page.
Notice that there is an "Edit Page" button on the page and that this takes you back to the gjs editor, as does the "Edit" option in the breadcrumbs.
Apply Patch
Navigate back to 'View As Page' and notice that the 'Edit Page' button has been removed.
The 'Edit' option in the breadcrumbs still allows you to navigate back to the gjs editor for the current page.