Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove edit button from grapes view as page #129

Conversation

AlexanderBlanchardAC
Copy link

Remove Edit button from grapes view as page as the editor can be accessed through the breadcrumbs and this option is more in keeping with the rest of Aspen.

TEST PLAN:

  1. Ensure Web Builder is enabled System Administration->Modules->Web Builder.
  2. Ensure that Grapes JS is enabled System Administration->System Variables-> Enable Grapes Editor
    Prior to applying patch:
  3. Navigate to Web Builder->Grapes Pages and select Add new.
  4. Create a page and click Open in Editor.
  5. Add some content using Grapes JS.
  6. Ensure you save the page.
  7. Navigate back to the list of pages using the breadcrumbs at the top of the editor. Click view as page.
  8. Notice that there is an "Edit Page" button on the page and that this takes you back to the gjs editor, as does the "Edit" option in the breadcrumbs.
    Apply Patch
  9. Navigate back to 'View As Page' and notice that the 'Edit Page' button has been removed.
  10. The 'Edit' option in the breadcrumbs still allows you to navigate back to the gjs editor for the current page.

Remove Edit button from grapes view as page as the editor can be
accessed through the breadcrumbs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant