See all locations enhancement #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When freezing a hold, fixed a bug where the date picker actions when selecting the thaw date were not using translated values.
Fixed a bug where when selecting radio button values in Facets (i.e. Search Within), it would display a different (previously selected) value as being selected.
…ounts Use the cloudLibrary settings that have a scope that matches the home library of the account that is doing the checkout (either the main account or linked card).
The New Materials Request email to staff will only try to send if it has not already been sent.
[pull] 24.09.00 from Aspen-Discovery:24.09.00
If the user agent contains spammy content (such as "sleep(" or "SELECT") return a 404 error. The check for spammy content is case insensitive.
Misc Bug Fixes for LiDA & Discovery
cloudLibrary with alternate cards bug fixes
so that a patron can see the edition of the records when looking through the 'Where is it' modal on the search results page, adds an 'edition' property to the Grouping_Item class, and update getRawItemDataFromDB() on GroupedWorkDriver instances so that edition is fetched from the database and included in a scopedItem's data. This ultimately adds the 'edition' property to the $summary variable in the getCopyDetails method on the GroupedWork_AJAX class, allowing it to be assigned to $interface, thus making it available to copyDetails.tpl.
adds a record's edition to the modal that opens upon the 'Where is it?' button being clicked on the search page. For records that do not have edition information attached to them, displays 'unknown' instead
In the 'Where is it?' modal, also display the cover for each record found. Only do so if Show Covers for Editions is enabled in Grouped Work Display Setting.
Chloe070196
force-pushed
the
see_all_locations_enhancement
branch
3 times, most recently
from
b42fc0a to
223262c
Compare
|
Works nicely, will look even better on system that shows the different covers for different editions. |
Chloe070196
merged commit 227bcdf
into
PTFS-Europe:see_all_locations_enhancement
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch enhancing the 'Where is it?' modal by adding edition information as well as book cover thumbnails, as request in ticket
Test plan
If testing without the patch, then neither the edition information nor the thumbnails will show