Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an MVP draft for the ILL patron request form in Aspen, which enables them to:
It is not fully functional yet (see comments), but further improvements will require further investigation and discussion before they can be implemented. It does, however, show that Aspen can consume the two relevant Koha API endpoints.
Current issues:
hardcoding
Interlibrary Loans Request page, meaning the ILL/MyRequests table in Aspen currently includes less
information than Koha's
I'm adding this as a draft PR so it can easily be found and viewed.
Test plan:
Note: in both ILL/MyRequests.php and ILL/NewRequestForm.php, it is likely that $user->ils_password will be empty, and needs to be temporarily replaced with the hardcoded Koha password of the test user you will masquerade as.
0 - Set up Koha so that is uses Freeform as its ILL
If using WSL: go to Koha Administration's System Preferences, and set staffClientBaseURL to
http:// instead of 'localhost'.
1 - In Aspen: Aspen Administration > Library Systems > Materials Request, scroll to 'Formats of Materials
that can be Requested', and click 'Set Materials Request Formats To Default'
2 - Repeat point 1 with 'Materials Request Form Fields'
3 - Navigate back to the top of the 'Materials Request' section, and set 'Materials Request System' to
'ILL Request System - Koha' (no point in doing so earlier, as point 1 and 2 will reset this to 'None'
3 - ensure that 'Enable Materials Request for the Public' is checked, then save
4 - Masquerade as a patron (they must be allowed to make materials request!)
5 - run a search, scroll to the bottom of the page, and click 'Submit Request'
6 - submit the form (empty, or filled in - no fields are currently required)
7 - notice the form reloads (the success message is TBA)
8 - navigate to http://< aspen host >: < aspen port >/ILL/MyRequests
9 - notice a new request has been added
10 - go to the Koha OPAC, and log in as the user you Masqueraded as.
11 - navigate to Your account > Interlibrary Loans Request
12 - notice a new request has been created