Fix displaying Alternate Titles and Authors in staff view

PTFS-Europe · May 7, 2024 · fc64a8f · fc64a8f
1 parent 850b862
commit fc64a8f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/code/web/RecordDrivers/GroupedWorkDriver.php b/code/web/RecordDrivers/GroupedWorkDriver.php
@@ -2220,20 +2220,20 @@ public function getAlternateTitles() {
 			$alternateTitles = [];
 			if (!empty($permanentId)) {
 				$alternateTitle->permanent_id = $permanentId;
-				$alternateTitle->find();
-				$alternateTitles = [];
-				while ($alternateTitle->fetch()) {
-					$alternateTitles[$alternateTitle->id] = clone $alternateTitle;
+				if ($alternateTitle->find()) {
+					while ($alternateTitle->fetch()) {
+						$alternateTitles[$alternateTitle->id] = clone $alternateTitle;
+					}
 				}
 
 				//Also look for any grouped works that do not have the language attached
 				if (strlen($permanentId) == 40) {
 					$permanentId = substr($permanentId, 0, 36);
 					$alternateTitle->permanent_id = $permanentId;
-					$alternateTitle->find();
-					$alternateTitles = [];
-					while ($alternateTitle->fetch()) {
-						$alternateTitles[$alternateTitle->id] = clone $alternateTitle;
+					if ($alternateTitle->find()) {
+						while ($alternateTitle->fetch()) {
+							$alternateTitles[$alternateTitle->id] = clone $alternateTitle;
+						}
 					}
 				}
 			}

diff --git a/code/web/release_notes/24.05.00.MD b/code/web/release_notes/24.05.00.MD
@@ -183,6 +183,7 @@
 - Error handling when viewing records that are not linked to a grouped work. (*MDN*)
 - Correct license included in repository based on VuFind original license. (*MDN*)
 - Optimize session table during nightly cron. (*MDN*)
+- Fix displaying Alternate Titles and Authors in staff view. (*MDN*)
 
 ## This release includes code contributions from
 - ByWater Solutions