Indra requested edits + Kerri's letter #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edits to text blurbs
brandonhundt
changed the title
- fix award-press container overflow - offset link underline - remove "Feature Episode" label from letter audio button
brandonhundt
commented
Dec 3, 2024
|
|
||
| allShowAudio.forEach((wrapper) => { | ||
| const audio = wrapper.querySelector('audio'); | ||
| const button = wrapper.querySelector('button'); | ||
| const progressSliderInput = wrapper.querySelector('.show-audio--slider input'); | ||
| const progressSliderInput = wrapper.querySelector(':where(.show-audio--slider, .welcome-audio--slider) input'); |
There was a problem hiding this comment.
Ah! Right on! Thanks Rick
brandonhundt
commented
Dec 3, 2024
| @@ -29,7 +29,6 @@ <h2 class="welcome-title">{{ welcome.title }}</h2> | |||
| %} | |||
| <button type="button" class="welcome-audio--button"> | |||
| <span class="play-icon" aria-label="Play"></span> | |||
| <span class="welcome-audio--button--label">Featured Episode</span> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14
PR Indra started with Edits. I've also made a few updates based on Indra's requests.
Including: