target/ppc: slb* using REQUIRE_SV #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GEN_PRIV and related CHK_* macros just assumed that variable named "ctx" would be in scope when they are used, and that it would be a pointer to DisasContext. Change these macros to receive the pointer explicitly.
mferst
reviewed
Jun 7, 2022
lrcoutinho
force-pushed
the
lrcoutinho-slbiag-review2
branch
from
4f14733 to
cdf64e6
Compare
mferst
reviewed
Jun 8, 2022
mferst
reviewed
Jun 8, 2022
mferst
reviewed
Jun 8, 2022
mferst
reviewed
Jun 8, 2022
mferst
reviewed
Jun 8, 2022
mferst
reviewed
Jun 8, 2022
mferst
reviewed
Jun 8, 2022
mferst
reviewed
Jun 8, 2022
| static void gen_slbfee_(DisasContext *ctx) | ||
| { | ||
| #if defined(CONFIG_USER_ONLY) | ||
| gen_inval_exception(ctx, POWERPC_EXCP_PRIV_REG); |
There was a problem hiding this comment.
This reminded me that we had a linux-user bug here, reported by Laurent Vivier in a previous discussion:
https://lists.gnu.org/archive/html/qemu-ppc/2022-03/msg00276.html
I'll prepare a patch to fix this...
Equivalent to CHK_SV and CHK_HV, but can be used in decodetree methods.
Also decode RIC, PRS and R operands.
Also decode RIC, PRS and R operands.
This initial version supports the invalidation of one or all TLB entries. Flush by PID/LPID, or based in process/partition scope is not supported, because it would make using the generic QEMU TLB implementation hard. In these cases, all entries are flushed.
lrcoutinho
force-pushed
the
lrcoutinho-slbiag-review2
branch
from
d127a8d to
0858f8f
Compare
mferst
approved these changes
Jun 9, 2022
lrcoutinho
force-pushed
the
lrcoutinho-slbiag-review2
branch
from
fac8d68 to
17967de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.