-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
target/ppc: Drop VECTOR_FOR_INORDER_I #95
Open
mferst
wants to merge
6
commits into
ferst-tcg-config_128
Choose a base branch
from
ferst-tcg-vector_for_inorder_i
base: ferst-tcg-config_128
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move vpmsum[bhw] to decodetree and drop the use of VECTOR_FOR_INORDER_I in helpers, since there is no need to access the elements in any particular order.
We just need to operate over each element, no need for any particular order.
We just need to operate over each element, no need for any particular order.
We just need to operate over each element, no need for any particular order. Also, use Vsr[BD] instead of the VBPERM[DQ]_INDEX macros, they are essentially the same thing.
The helper does not operate in place, elements already processed are not reused in the calculations, and the index is only used to operate over each element, so there is no order requirement.
As in vpkpx, the helpers do not operate in place, elements already processed are not reused in the calculations, and the index is only used to operate over each element, so the use of VECTOR_FOR_INORDER_I is not required. This macro is also removed, as this is its last use.
alqotel
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
luporl
approved these changes
Jun 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.