add bpf.o to craned rpm pack #384
Open
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
这个东西是处于可以合并的状态吗 还是还有修改需要提交 |
Nativu5
reviewed
Dec 5, 2024
| if(ENABLE_BPF) | ||
| install(FILES | ||
| ${CMAKE_BINARY_DIR}/src/Misc/BPF/cgroup_dev_bpf.o | ||
| DESTINATION /etc/crane/ |
There was a problem hiding this comment.
这个安装位置还是有待商榷，/etc 下面应该放 .o 文件吗？
There was a problem hiding this comment.
我的意思是 Linux 系统对于 /etc 目录下放的东西是有特定要求的：https://en.wikipedia.org/wiki/Filesystem_Hierarchy_Standard
.o 放在 /etc 下面可以，但不符合规范。
There was a problem hiding this comment.
这个放/var/crane/craned/下面吧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.