PHPStan setup: various tweaks #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to `phpstan.neon.dist` to allow for overloading the file. Also: if the configuration file is one of the default files (`phpstan.neon.dist` or `phpstan.neon`), there is no need to pass the path on the command line in CI.
... for push builds. Pull request builds still need to run as branch protection has been enabled with required statusses.
* Set the `phpVersion` to `70100` (lowest possible). This prevents PHPStan throwing notices which are related to the PHP version on which PHPStan is being _run_, in contrast to the PHP version which the code _supports_. * With the `phpVersion` being set, PHPStan can now run on the `latest` PHP version in CI, though as long as the max PHPUnit version is PHPUnit 7.5, this _will_ throw deprecation notices, so let's leave that for now. Includes minor update to the config for something which is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PHPStan: rename configuration file
... to
phpstan.neon.distto allow for overloading the file.Also: if the configuration file is one of the default files (
phpstan.neon.distorphpstan.neon), there is no need to pass the path on the command line in CI.GH Actions: don't run PHPStan when only XML files have been updated
... for push builds. Pull request builds still need to run as branch protection has been enabled with required statusses.
PHPStan: set the phpVersion
phpVersionto70100(lowest possible). This prevents PHPStan throwing notices which are related to the PHP version on which PHPStan is being run, in contrast to the PHP version which the code supports.phpVersionbeing set, PHPStan can now run on thelatestPHP version in CI, though as long as the max PHPUnit version is PHPUnit 7.5, this will throw deprecation notices, so let's leave that for now.Includes minor update to the config for something which is no longer needed.
Suggested changelog entry
N/A