Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: mention the signing key for phars #158

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

lucc
Copy link

@lucc lucc commented Dec 11, 2023

Description

The signing key used for the phars is mentioned in the README. This can serve as a "trust anchor" for consumers.

Suggested changelog entry

Related issues/external references

Fixes #157

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.

The signing key used for the phars is mentioned in the README.  This can
serve as a "trust anchor" for consumers.
@lucc
Copy link
Author

lucc commented Dec 11, 2023

@jrfnl please verify that this is really your key used for signing the phars :)

@jrfnl jrfnl added this to the 3.x Next milestone Dec 11, 2023
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucc Thank you for making these changes 🙏🏻 . I have double and triple checked and yes, that is the correct key 😉

@jrfnl
Copy link
Member

jrfnl commented Dec 11, 2023

I'm re-reading @theseer's reply, which now has me wondering if the change to the phive command is correct. It uses the public key fingerprint in this PR, but in Arne's example, the command uses the key ID....

@theseer
Copy link

theseer commented Dec 11, 2023

I'm re-reading @theseer's reply, which now has me wondering if the change to the phive command is correct. It uses the public key fingerprint in this PR, but in Arne's example, the command uses the key ID....

No worries. Both are fine. The more common way is to use the key ID but we explicitly also support the full fingerprint.
If you look at it, you'll see that the ID is actually a part of the fingerprint :)

@jrfnl
Copy link
Member

jrfnl commented Dec 11, 2023

@theseer Excellent! Thank you so much for your help and @lucc for preparing this update. Merging now.

@jrfnl jrfnl merged commit 040f675 into PHPCSStandards:master Dec 11, 2023
40 checks passed
@lucc lucc deleted the gpg-key branch December 11, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document public key used for phar signing
3 participants