GH Actions: automate yearly update of test file #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every year two of the `fixed` files for the tests for the `Squiz.Commenting.FileComment` sniff need to be updated to ensure they have the correct expected year. See: squizlabs/PHP_CodeSniffer 2793, squizlabs/PHP_CodeSniffer 3525, squizlabs/PHP_CodeSniffer 3737 So far this was always done manually and all PRs created in the new year would show a failing build until that PR was merged and the other PRs rebased. This commit introduces a new workflow to automate those updates and automatically creates a PR at 5 minutes past midnight on the new year. All that needs to happy then is to merge the PR promptly and all will be good. Obviously, the true test of whether this workflow works will be on January 1st, but I've done some testing by manually reverting the change from January of this year and it all seems to look good. Refs to actions used in this workflow: * https://github.com/jacobtomlinson/gha-find-replace * https://github.com/peter-evans/create-pull-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Every year two of the
fixedfiles for the tests for theSquiz.Commenting.FileCommentsniff need to be updated to ensure they have the correct expected year. See: squizlabs/PHP_CodeSniffer#2793, squizlabs/PHP_CodeSniffer#3525, squizlabs/PHP_CodeSniffer#3737So far this was always done manually and all PRs created in the new year would show a failing build until that PR was merged and the other PRs rebased.
This commit introduces a new workflow to automate those updates and automatically creates a PR at 5 minutes past midnight on the new year.
All that needs to happy then is to merge the PR promptly and all will be good.
Obviously, the true test of whether this workflow works will be on January 1st, but I've done some testing by manually reverting the change from January of this year and it all seems to look good.
Refs to actions used in this workflow:
Suggested changelog entry
N/A