Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions/label new PRs: use v1 floating tag #101

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Nov 11, 2023

Description

Using master for action runners is bad practice (as it opens you up to unexpectedly moving to a new major containing breaking changes), but so far, the srvaroa/labeler action did not have a floating/moving v1 tag.

This tag has now been added, so updating the workflow to use it.

The action has also tagged version v1.7.2, which should fix an issue I previously reported where tags were being removed, even though the config forbids this.

Suggested changelog entry

N/A

Related issues/external references

Refs:

Using `master` for action runners is bad practice (as it opens you up to unexpectedly moving to a new major containing breaking changes), but so far, the `srvaroa/labeler` action did not have a floating/moving `v1` tag.

This tag has now been added, so updating the workflow to use it.

The action has also tagged version `v1.7.2`, which should fix an issue I previously reported where tags were being removed, even though the config forbids this.

Refs:
* srvaroa/labeler 104
* srvaroa/labeler 110
* https://github.com/srvaroa/labeler/releases/tag/v1.7.2
@jrfnl jrfnl added this to the 3.8.0 milestone Nov 11, 2023
@jrfnl jrfnl enabled auto-merge November 11, 2023 19:41
@jrfnl jrfnl merged commit 265adff into master Nov 11, 2023
58 checks passed
@jrfnl jrfnl deleted the feature/ghactions-labeler-use-v1 branch November 11, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant