Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path resolution in check_samplesheet #56

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Fix path resolution in check_samplesheet #56

merged 3 commits into from
Sep 19, 2023

Conversation

nebfield
Copy link
Member

@nebfield nebfield commented Sep 19, 2023

Before

Relative paths were resolved relative to a work directory parent

e.g. stuff/work/a1/c2/samplesheet.csv -> stuff/cineca.vcf.gz

This can be quite fragile if you change the default work directory location and is quite confusing behaviour.

It also breaks running the test profile from nextflow directly (nextflow run pgscatalog/pgsc_calc) with local files.

Now

The samplesheet path is resolved and relative genome paths are joined with the parent directory.

e.g. stuff/work/a1/c2/samplesheet.csv -> original_dir/samplesheet.csv -> original_dir/cineca.vcf.gz

New features:

  • Doesn't try to resolve remote paths (s3:// or https:// prefix), trust nextflow to handle this
  • Throw an error if you try to use insecure remote paths (http://)
  • Will allow support for running test profile offline with nextflow run pgscatalog/pgsc_calc and nextflow run main.nf

Closes #51

@nebfield nebfield changed the base branch from main to dev September 19, 2023 13:20
@nebfield nebfield marked this pull request as ready for review September 19, 2023 13:30
@nebfield nebfield changed the title Fix resolve path behaviour Fix path resolution in check_samplesheet Sep 19, 2023
Copy link
Member

@smlmbrt smlmbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I'd really know if anything was wrong though.... better to ask Laurent? I guess the proof will be whether it works in situ

@nebfield
Copy link
Member Author

yes, I think it's simplest to merge and test offline 😄

@nebfield nebfield merged commit 60114fa into dev Sep 19, 2023
1 check passed
@nebfield nebfield deleted the fix_resolve branch September 19, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change relative path discovery behaviour
2 participants