Move community code into core module #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears you've reformated the whole project? the point of the rachet mechanism is that it should only need to update classes as they get modified, to avoid precisely these inmense diffs |
|
Reformatting was due to copying over the restrict dependencies and then replacing the dependencies with the corresponding replacements. Mostly its just moving into core |
cswhite2000
force-pushed
the
move-core
branch
from
d31538c
to
fd58471
Compare
cswhite2000
changed the title
Signed-off-by: Christopher White <[email protected]>
cswhite2000
force-pushed
the
move-core
branch
from
fd58471
to
271103b
Compare
Pablete1234
approved these changes
Nov 22, 2024
|
Nicely done! Thanks for taking care of this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves main community code into core directory
This is a prerequisite for multi version support in community
Decided to do the gradle switch in a separate pr.
I've disabled spotless in this PR, as the move breaks ratcheting