Allow players with pgm.staff permission node to view disguised players' nicks and skins #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice fix! Thanks 👍 |
|
Oh @dentmaged can't merge until you sign your commit. |
…s' nicks and skins Signed-off-by: William Jeffcock <[email protected]>
dentmaged
force-pushed
the
view-nicks-fix
branch
from
eb785d0
to
9c62cfc
Compare
|
Awesome! Thanks for fixing the commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have the permission node
pgm.staff, you can see through nicks in tab list, commands and chat. However, since Community uses the permission nodecommunity.nick.view-skinswhen setting a fake name and skin, it is possible to see through nicknames in PGM, but still see the fake player model.